Remove legacy RecordStore
support
#3374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see from usage locations, we've been using
()
implementation for quite some time, but farmer was still able to serve very old clients that relied on requests through Kademlia's DHT and itsRecordStore
implementation.RecordStore
has synchronous API and doesn't allow us to do more advanced iterative lookups, which is why we have implemented custom logic and abandonedRecordStore
usage.This moves
DummyRecordStore
frompiece_provider
module toconstructor
and simply prunes record store configuration option with all generics that it involved.Code contributor checklist: