-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to self-hosted ephemeral linux runners all workflows #3373
Conversation
update RAM specs revert test branch
e3c0960
to
28239d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions, the overall shape makes sense to me now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I’m not sure how to do a helpful review here, CI seems to be failing?
082d08a
to
16e7991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I guess if it needs to be in main
we can force a merge and make sure it passes there.
This PR changes our CI workflows to use Linux ephemeral self hosted runners on AWS spot instances, instead of dedicated runners. A follow up PR will be done to switch windows over once the base image is ready.
Code contributor checklist: