Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to self-hosted ephemeral linux runners all workflows #3373

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

DaMandal0rian
Copy link
Member

@DaMandal0rian DaMandal0rian commented Feb 7, 2025

This PR changes our CI workflows to use Linux ephemeral self hosted runners on AWS spot instances, instead of dedicated runners. A follow up PR will be done to switch windows over once the base image is ready.

Code contributor checklist:

update RAM specs

revert test branch
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions, the overall shape makes sense to me now

nazar-pc
nazar-pc previously approved these changes Feb 8, 2025
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@teor2345 teor2345 removed their request for review February 10, 2025 02:05
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I’m not sure how to do a helpful review here, CI seems to be failing?

Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I guess if it needs to be in main we can force a merge and make sure it passes there.

@DaMandal0rian DaMandal0rian merged commit c67d141 into main Feb 10, 2025
8 checks passed
@DaMandal0rian DaMandal0rian deleted the change-linux-runners branch February 10, 2025 10:08
@DaMandal0rian DaMandal0rian mentioned this pull request Feb 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants