Give FraudProofVariant explicit codec indexes #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
nazar-pc,
rg3l3dr,
vedhavyas and
NingLin-P
as code owners
nazar-pc
reviewed
Dec 4, 2024
teor2345
force-pushed
the
fix-fraud-comment
branch
from
ed967a9 to
3b42131
Compare
teor2345
changed the title
teor2345
changed the title
nazar-pc
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conditionally compiled variant changes enum variant numbering for everything after that variant, so giving the variants explicit indexes means that the order of the
Dummyvariant doesn't matter.And in Rust, conditional compilation only applies to the item, variant, or block:
https://doc.rust-lang.org/reference/conditional-compilation.html#forms-of-conditional-compilation
Code contributor checklist: