Split produce_bundle into smaller methods #3276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for #3254, this PR splits
DomainBundleProducer::produce_bundle()
into smaller methods.I've left the code in the same order as the original method, so it is easier to review. I'll do further cleanups in the test refactor PRs.
git diff --ignore-space-change
might help with reviews, because some of the code is now at the top level of the new methods.Code contributor checklist: