Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split produce_bundle into smaller methods #3276

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

teor2345
Copy link
Member

@teor2345 teor2345 commented Dec 3, 2024

To prepare for #3254, this PR splits DomainBundleProducer::produce_bundle() into smaller methods.

I've left the code in the same order as the original method, so it is easier to review. I'll do further cleanups in the test refactor PRs.

git diff --ignore-space-change might help with reviews, because some of the code is now at the top level of the new methods.

Code contributor checklist:

@nazar-pc
Copy link
Member

nazar-pc commented Dec 3, 2024

About whitespace there is also a checkbox in GitHub's UI and you can add w=1 query parameter to URL in other places on GitHub where such button is not physically present on the page (like branch comparison page)
Знімок екрана з 2024-12-03 04-49-46

@teor2345 teor2345 added refactor execution Subspace execution labels Dec 3, 2024
@teor2345 teor2345 added this pull request to the merge queue Dec 3, 2024
Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Merged via the queue into main with commit cd44905 Dec 3, 2024
8 checks passed
@teor2345 teor2345 deleted the split-produce-bundle branch December 3, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Subspace execution refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants