Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More x86-64 variants of container images #3220

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Nov 7, 2024

This way we have not just Skylake build, but also x86-64-v2, x86-64-v3 and can have Zen4+ optimized builds (if runner would support it).

Follow-up to this will replace building of executables on host OS with extraction from container images, which will simplify CI pipeline and even reduce the time it takes to build everything (with a small caveat that we technically build more variants now, but we do it concurrently, but it should at least not be slower overall).

As a bonus it is now possible to cross-compile to x86-64, not just from. Not very practical without non-x86-64 runners, but hey, at least we have it.

CI run confirming successful operation: https://github.com/autonomys/subspace/actions/runs/11725994004/job/32663591077

Code contributor checklist:

Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I didn’t run the resulting executables.

@nazar-pc nazar-pc added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 5800e4f Nov 7, 2024
17 checks passed
@nazar-pc nazar-pc deleted the docker-more-x86-64-variants branch November 7, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants