Temporarily log panic messages inside rayon CUDA plotter #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
nazar-pc,
shamil-gadelshin and
rg3l3dr
as code owners
nazar-pc
reviewed
Nov 4, 2024
teor2345
commented
Nov 5, 2024
teor2345
force-pushed
the
rayon-panic-message
branch
from
b63f6c8 to
badbfb4
Compare
nazar-pc
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a bug report of a panic inside the rayon CUDA plotter.
Currently rayon doesn't log panic messages from
spawn*()calls. Until we get that default changed, this PR will log the panic message if it happens again.Code contributor checklist: