Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary re-export of jsonrpsee #3202

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Remove unnecessary re-export of jsonrpsee #3202

merged 1 commit into from
Nov 3, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Nov 2, 2024

Probably a historical artifact of the node client implementation

Code contributor checklist:

@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner November 2, 2024 02:37
@nazar-pc nazar-pc enabled auto-merge November 2, 2024 02:37
teor2345
teor2345 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@nazar-pc nazar-pc added this pull request to the merge queue Nov 3, 2024
Merged via the queue into main with commit 867cb20 Nov 3, 2024
8 checks passed
@nazar-pc nazar-pc deleted the remove-unnecessary-re-export branch November 3, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@shamil-gadelshin shamil-gadelshin Awaiting requested review from shamil-gadelshin

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazar-pc @teor2345