Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid replotting the same sector more than once #3160

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nazar-pc
Copy link
Member

If replotting was taking too long it was possible for new segment to be archived and replotting to be triggered again for the same sector, resulting in mishmash of contents written to disk.

While it was nice to only insert entry into sectors_being_modified due to it being still available for farming in the meantime, the value of this is limited even on devnet, let alone on bigger networks with more space pledged.

The fix is to insert an entry before even starting plotting and removing at the very end.

Code contributor checklist:

@nazar-pc nazar-pc added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 2f46ae7 Oct 22, 2024
8 checks passed
@nazar-pc nazar-pc deleted the avoid-replotting-the-same-sector branch October 22, 2024 11:31
@nazar-pc nazar-pc mentioned this pull request Oct 31, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants