Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max object size and DSN listen on address arguments to gateway #3157

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add max object size and DSN listen on address arguments to gateway #3157

merged 2 commits into from
Oct 22, 2024

Conversation

teor2345
Copy link
Member

This PR adds two command line arguments to the gateway:

  • the maximum object size to fetch
  • DSN listen addresses, for debugging

Code contributor checklist:

@teor2345 teor2345 added the improvement it is already working, but can be better label Oct 21, 2024
@teor2345 teor2345 self-assigned this Oct 21, 2024
nazar-pc
nazar-pc previously approved these changes Oct 22, 2024
View reviewed changes
Base automatically changed from gateway-fetch to main October 22, 2024 12:56
@nazar-pc nazar-pc dismissed stale reviews from shamil-gadelshin and themself October 22, 2024 12:56

The base branch was changed.

@nazar-pc nazar-pc merged commit 96a36fd into main Oct 22, 2024
8 checks passed
@nazar-pc nazar-pc deleted the gateway-args branch October 22, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc left review comments

@shamil-gadelshin shamil-gadelshin shamil-gadelshin left review comments

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees

@teor2345 teor2345

Labels
improvement it is already working, but can be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @nazar-pc @shamil-gadelshin