Farmer fixes #3154
Merged
Farmer fixes #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn write(&self) -> &DirectIoFile { | ||
| // Always the same file or else overlapping writes will be corrupted due to | ||
| // read/modify/write internals, which are in turn caused by alignment requirements | ||
| &self.files[0] |
There was a problem hiding this comment.
This is rather confusing despite the comment. Can you rephrase to explain writing API for a single file and reading API from different files?
There was a problem hiding this comment.
When you read it is fine to read concurrently, but due to alignment requirements when we do not write chunks of 512 bytes at a multiple of 512 bytes offset, we need to first read 512 bytes, then replace what we want to modify in those bytes with new contents and write it back to disk. We can't just write arbitrary sizes at arbitrary offsets with Direct IO, see the DirectIoFile implementation.
shamil-gadelshin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes, both caused issues with pieces, but due to different reasons.
Code contributor checklist: