Implement gateway RPC launch and piece getting #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
shamil-gadelshin,
nazar-pc and
rg3l3dr
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
force-pushed
the
gateway-fetch
branch
from
ef2c7f2 to
185abe9
Compare
44 tasks
teor2345
force-pushed
the
gateway-fetch
branch
from
185abe9 to
a58d52c
Compare
|
This should work too, I implemented validation because it was pretty easy. |
teor2345
changed the title
nazar-pc
previously approved these changes
Oct 21, 2024
nazar-pc
previously approved these changes
Oct 21, 2024
teor2345
dismissed
nazar-pc’s stale review
The merge-base changed after approval.
nazar-pc
previously approved these changes
Oct 22, 2024
|
|
||
| // Fall back to the node's bootstrap nodes. | ||
| if bootstrap_nodes.is_empty() { | ||
| debug!( | ||
| dsn_bootstrap_nodes = ?farmer_app_info.dsn_bootstrap_nodes, | ||
| bootstrap_nodes = ?farmer_app_info.dsn_bootstrap_nodes, |
There was a problem hiding this comment.
I intentionally left it as dsn_bootstrap_nodes because it came from the node to distinguish from explicit option
nazar-pc
previously approved these changes
Oct 22, 2024
teor2345
dismissed
nazar-pc’s stale review
The merge-base changed after approval.
nazar-pc
previously approved these changes
Oct 22, 2024
teor2345
dismissed
nazar-pc’s stale review
The merge-base changed after approval.
|
Some related to auto-merge broke here, I tried to approve it a few times and it didn't move forward, so I force-merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the gateway get pieces from the DSN, validate them, and reconstruct them into objects.
It also:
PieceValidatordebug formattingCode contributor checklist: