Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimise features used by RPC servers, support IPv6 CORS #3146

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Minimise features used by RPC servers, support IPv6 CORS #3146

merged 2 commits into from
Oct 18, 2024

Conversation

teor2345
Copy link
Member

@teor2345 teor2345 commented Oct 18, 2024 •
edited
Loading

This PR makes two changes to RPC servers:

  • add IPv6 localhost address to default CORS rules: sometimes localhost will resolve to IPv4, IPv6, or both, depending on the local C library and DNS server
  • minimise features used by RPC server crates: I tested this by compiling each RPC server crate by itself
    • this also requires a fix to the gateway tokio features

Code contributor checklist:

@teor2345 teor2345 added the improvement it is already working, but can be better label Oct 18, 2024
@teor2345 teor2345 self-assigned this Oct 18, 2024
@teor2345 teor2345 enabled auto-merge October 18, 2024 06:31
@teor2345 teor2345 added this pull request to the merge queue Oct 18, 2024
@nazar-pc nazar-pc removed this pull request from the merge queue due to a manual request Oct 18, 2024
@nazar-pc nazar-pc merged commit f44d204 into main Oct 18, 2024
10 checks passed
@nazar-pc nazar-pc deleted the min-rpc-features branch October 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

@NingLin-P NingLin-P Awaiting requested review from NingLin-P NingLin-P is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees

@teor2345 teor2345

Labels
improvement it is already working, but can be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @nazar-pc