PieceGetter::get_pieces() in FarmerPieceGetter
#3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariolina
pushed a commit
that referenced
this pull request
Oct 17, 2024
…tter `PieceGetter::get_pieces()` in `FarmerPieceGetter`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new method introduced in #3132 for
FarmerPieceGetter.Next I'll be adding
get_piecesAPI to piece caches for higher efficiency, refactoring cluster API to use stream requests for pieces for higher performance and then implementingPieceGetter::get_pieces()forClusterPieceGetter.Still, everything should continue to work in this PR and regular farming should be able to take advantage of faster piece retrieval already.
Code contributor checklist: