Fix sector scrub #2634
Merged
Fix sector scrub #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all this PR implements
--dry-runoption for scrubbing, which was both useful for debugging for me and could be useful in some other scenarios for farmers.Second, due to incorrect assumptions of sector layout scrubbing wasn't working correctly and due to #2633 was silently expiring all sectors, forcing replotting. Reading sector as a series of opaque bytes rather than some specific contents fixes that and makes it more resilient to potential future changes.
Tested with both correctly plotted farm and corrupted one, works as expected for me.
Code contributor checklist: