Improvements around unsafe #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Feb 28, 2024
| @@ -261,6 +257,8 @@ pub fn recover_extended_record_chunks( | |||
| erasure_coding: &ErasureCoding, | |||
| ) -> Result<Box<[Scalar; Record::NUM_S_BUCKETS]>, ReadingError> { | |||
| // Restore source record scalars | |||
| // TODO: Recover into `Box<[Scalar; Record::NUM_S_BUCKETS]>` or else conversion into `Box` below | |||
| // might leak memory | |||
There was a problem hiding this comment.
This looks like a rather important TODO. Is there a follow up PR to this?
There was a problem hiding this comment.
It is essentially an upstream https://github.com/sifraitech/rust-kzg improvement. It is not that critical and basically means that compiler allocator can allocate more memory than necessary. See https://blog.polybdenum.com/2024/01/17/identifying-the-collect-vec-memory-leak-footgun.html for example of such issue. I don't think it is a big deal here and didn't notice issues related to this, just noted something we can improve in the future.
vanhauser-thc
added
audited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was auditing code in my head and found a few places where memory can hypothetically leak and a few tiny optimizations.
Code contributor checklist: