Pause Substrate sync while doing sync from DSN #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
pause-substrate-sync
branch
from
56283e4 to
65f0d10
Compare
|
Rebased against |
shamil-gadelshin
previously approved these changes
Jun 29, 2023
# Conflicts: # crates/subspace-fraud-proof/Cargo.toml # test/subspace-test-client/Cargo.toml
shamil-gadelshin
approved these changes
Jun 29, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
jfrank-summit
pushed a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages autonomys/substrate#52 (hence Substrate upgrade) to pause Substrate sync process (essentially all outgoing requests, see autonomys/substrate#52) while sync from DSN is happening.
Without this pruned nodes on the network result in a decreased reputation of connected peers and a lot of unnecessary reconnections/disconnections.
This closes last requirement for #1514, which I'll resolve after extra testing.
For review purposes just ignore all Cargo.toml changes, there are very few changes outside of that.
Code contributor checklist: