-
Notifications
You must be signed in to change notification settings - Fork 22
Trail of bits audit - Issue #3 (Improper error handling) #352
Trail of bits audit - Issue #3 (Improper error handling) #352
Conversation
…trail-of-bits-audit-issue-3-improper-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this PR will get rid of errorLogger
in many places, but we also want errors to be logged.
When I looked at setError()
code in store.ts
, I couldn't see any call to errorLogger()
?
@isSerge I'm happy with it as is. However, what about embedding |
@ozgunozerk |
@ozgunozerk also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did inspect during draft, looks great to me
Introduced new error titles:
Draft, since we need to update the current generic error message:
Closes #337