Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #22

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

mworchel
Copy link
Contributor

Hi,

this PR fixes several issues (such as #15) when trying to run the code using a Windows machine. I tried to be as clear as possible with the commit messages but if something does not immediately make sense, don't hesitate to ask. The large diff in the main scripts is not as large as it seems (and more obvious if you disable whitespace comparisons). Essentially, I just wrapped the scripts in a

if __name__ == '__main__':

Otherwise, they will not run due to the way the multiprocessing lib is implemented under Windows (see https://stackoverflow.com/a/18205006)

The cause for the error in #15 seems to be that the type np.int64 corresponds to long long under Windows and not long as assumed by the code. I fixed it by using Cython's type cnp.int64_t instead of long, which should be resolved to the right type, independent of the platform.

@m-niemeyer
Copy link
Collaborator

Hey mworchel, that's great - thanks a lot for doing this. I don't have access to a Windows machine, but I assume you tested it so I will go ahead and merge your changes Thanks again for this contribution!

@m-niemeyer m-niemeyer merged commit 969b17c into autonomousvision:master Jun 23, 2020
@mworchel
Copy link
Contributor Author

Yes, I successfully tested it on two Windows machines.

Thanks for the merge!

@m-niemeyer
Copy link
Collaborator

That's great, thanks a lot again for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants