Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR fixes several issues (such as #15) when trying to run the code using a Windows machine. I tried to be as clear as possible with the commit messages but if something does not immediately make sense, don't hesitate to ask. The large diff in the main scripts is not as large as it seems (and more obvious if you disable whitespace comparisons). Essentially, I just wrapped the scripts in a
Otherwise, they will not run due to the way the
multiprocessing
lib is implemented under Windows (see https://stackoverflow.com/a/18205006)The cause for the error in #15 seems to be that the type
np.int64
corresponds tolong long
under Windows and notlong
as assumed by the code. I fixed it by using Cython's typecnp.int64_t
instead oflong
, which should be resolved to the right type, independent of the platform.