Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/event_parsing #17

Merged
merged 9 commits into from
Jan 17, 2025
Merged

fix/event_parsing #17

merged 9 commits into from
Jan 17, 2025

Conversation

mkabtoul
Copy link
Contributor

Fixes event/actions parsing from the Launcher to each Component/Monitor

  • Uses serialized events (str) instead of events as internal event/action dictionary keys

@mkabtoul mkabtoul requested a review from aleph-ra January 17, 2025 14:04
@mkabtoul mkabtoul self-assigned this Jan 17, 2025
aleph-ra
aleph-ra approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@aleph-ra aleph-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged.

@aleph-ra aleph-ra merged commit 3c24f53 into main Jan 17, 2025
4 checks passed
@aleph-ra aleph-ra deleted the fix/event_parsing branch January 17, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleph-ra aleph-ra aleph-ra approved these changes

Assignees

@mkabtoul mkabtoul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkabtoul @aleph-ra