Update from upstream repo facebookincubator/create-react-app@master #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the code got updated from `detect()` to `choosePort` while the comment did not.
Replaced `it's` with `its`
The launch configuration code provided is not compatible with VSCode since version 1.19. The proposed documentation change is based on the response by a VSCode team member. References: #3602 (comment) microsoft/vscode#40293 (comment)
* use safer/more aesthetic syntax * fix typo
Replace `provide a lot value` with `provide a lot of value`.
* Fix path regex match bug * Use the escape-string-regexp package to escape regex characters * Remove redundant character escape from path * Add removed escape of backslashes
Add TypeScript to **Popular Alternatives**
Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to #2636.
awk splits lines based on spaces, which causes directory names with spaces to end up in other fields. Using a for loop allows us to print from the 9th field onwards instead of just the 9th field.
* added getProxy getProxy checks proxy settings from process.env.https_proxy or Yarn (NPM) config (.npmrc) * changed yarn for npm to get https-proxy default value for https-proxy is null, not undefined like in yarn
* Extend --scripts-version to include .tar.gz format * Removal of debug console.log
* Port cra.sh development task to javascript * Port cra.sh development task to javascript Use absolute path when generating .tgz path
* Added documentation for contributors using windows 10 Hopefully encourages devs on Windows machine to contribute * corrected the wordings a little
* Replacing literal 'build' with `buildFolder` variable * Cleaning up the printHostingInstructions a bit * Fixing undefined variable
* Use proxy for all request methods other than GET * Add comment
* Lint against files with old license * Update e2e-simple.sh * Update e2e-simple.sh * oh no
* add link to deployment docs after build * Update printHostingInstructions.js
* Use latest npm in e2e tests * Keep default npm version in "simple" test * Try to fix CI by using a version that supports Yarn
* Try to use Yarn in more E2E scripts * Keep using npm pack * Maybe this will fix Windows? * Try this
* Separate old Node E2E test * Try this for old node
* Run e2e-simple in a realistic scenario * Use npx for everything * oops
* Convert e2e-installs * Convert kitchensink tests * Upgrade npm for kitchensink
* This doesn't look needed anymore * Remove unnecessary rebuilds
It's been here long enough.
* Switch to Yarn Workspaces * Feedback * Move flowconfig * Use publish script * Keep git status check * Fix Flow without perf penalty * Remove Flow from package.json "test" * Try running it from script directly (?) * Try magic incantations * lol flow COME ON * Try to skip Flow on AppVeyor * -df * -df * -df * Try to fix CI * Revert unrelated changes * Update CONTRIBUTING.md
* This is a good default. Adds approx 4 seconds to install time, but can save some headaches. * Add no lockfile for add, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The upstream repository
facebookincubator/create-react-app@masterhas some new changes that aren't in this fork. So, here they are, ready to be merged! 🎉If this pull request can be merged without conflict, you can publish your software with these new changes. Otherwise, fix any merge conflicts by clicking the
Resolve Conflictsbutton.If you like Backstroke, consider donating to help us pay for infrastructure here. Backstroke is a completely open source project that's free to use, but we survive on sponsorships and donations. Thanks for your support! Help out Backstroke.
Created by Backstroke (I'm a bot!)