fix(UI-1321): fix slack oauth edit #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J1za
approved these changes
Feb 11, 2025
RonenMars
force-pushed
the
ronen/fix/slack-oauth
branch
from
763f37f to
a241881
Compare
|
🎉 This PR is included in version 2.140.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can't edit Slack connections
Observed in my local server (head = main branch), not in prod.
After initializing a Slack OAuth connection, the auth_type is set (by the frontend, not the backend) to "oauthDefault". This is fine, but the web UI (v2.135.0) doesn't know this value yet, so if the user tries to edit the connection, they see this:
Linear Ticket
https://linear.app/autokitteh/issue/UI-1321/cant-edit-slack-connections
What type of PR is this? (check all applicable)