Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce padding in icon input prefix #990

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

sgimama
Copy link
Contributor

@sgimama sgimama commented Nov 3, 2024

AG-13803

@sgimama sgimama self-assigned this Nov 3, 2024
@sgimama sgimama requested a review from a team as a code owner November 3, 2024 22:45
Copy link

changeset-bot bot commented Nov 3, 2024

🦋 Changeset detected

Latest commit: 954d4a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@autoguru/overdrive Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sgimama sgimama marked this pull request as draft November 3, 2024 22:47
@sgimama sgimama marked this pull request as ready for review November 3, 2024 22:56
Copy link
Contributor

@amir-zahedi amir-zahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-04 at 2 32 48 pm @sgimama can we investigate the cause of this change please. Also it seems to to me that we can globally apply the smaller paddings to inputs with `size` prop value of small instead of using a container query

@amir-zahedi amir-zahedi self-requested a review November 6, 2024 01:14
@amir-zahedi amir-zahedi merged commit 4c8dc14 into main Nov 6, 2024
7 checks passed
@amir-zahedi amir-zahedi deleted the featureAG-13803-add-currency-input-field branch November 6, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants