Added missing logic to disable help.

author · Apr 30, 2020 · 130de1b · 130de1b
1 parent 8bfa21c
commit 130de1b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@author.io/shell",
-  "version": "1.3.11",
+  "version": "1.3.12",
   "description": "A micro-framework for creating CLI-like experiences. This supports Node.js and browsers.",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/base.js b/src/base.js
@@ -16,14 +16,16 @@ export default class Base {
   #name = 'Unknown'
   #middleware = new Middleware()
   #hasCustomDefaultHandler = false
-  #defaultHandler = function () {
+  #defaultHandler = function (meta) {
     if (this.parent !== null && this.parent.hasCustomDefaultHandler) {
       return this.parent.defaultHandler(...arguments)
     } else if (this.shell.hasCustomDefaultHandler) {
       return this.shell.defaultHandler(...arguments)
     }
 
-    console.log(this.help)
+    if (this.#autohelp) {
+      console.log(this.help)
+    }
   }
 
   constructor(cfg = {}) {

diff --git a/test/unit/01-sanity/01-sanity.js b/test/unit/01-sanity/01-sanity.js
@@ -131,7 +131,8 @@ test('Subcommand Config', t => {
 //   const shell = new Shell({
 //     name: 'test',
 //     version: '1.0.0',
-//     defaultHandler: () => console.log('yo'),
+//     disableHelp: true,
+//     // defaultHandler: () => console.log('yo'),
 //     commands: [
 //       {
 //         name: 'account',
@@ -144,6 +145,9 @@ test('Subcommand Config', t => {
 //             name: 'create',
 //             description: 'Create a user account.',
 //             arguments: '<email>',
+//             help () {
+//               return 'overridden help'
+//             },
 //             flags: {
 //               name: {
 //                 alias: 'n',