Fix resources/portal/static/img/* were excluded from docker build #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung2744
reviewed
Jun 13, 2024
|
|
||
| resources/**/generated | ||
| resources/portal/static/* | ||
| !resources/portal/static/img/* |
There was a problem hiding this comment.
Oh why I thought the build pipeline should generate the images?
There was a problem hiding this comment.
The images inside img is static.
There was a problem hiding this comment.
The real problem is we use the same directory to contain generated assets and static assets. But that is another issue.
tung2744
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug