Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seczetta risk integration + release v0.20.0 #277

Merged
merged 19 commits into from
Apr 2, 2021

Conversation

thook-sz
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Initial commit of the SecZetta / Auth0 integration

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Can you run npm run format to get the spacing consistent?

@thook-sz
Copy link
Contributor Author

Can you run npm run format to get the spacing consistent?

I am not sure what this means. Do I need to install npm and node to just run that simple command?

@joshcanhelp
Copy link
Contributor

@thook-sz My assumption it that you'd have it installed already but, if not, I can run that for you, no worries 👍 Just let me know when you're ready for a re-review and make sure I'm able to commit to your branch here.

@thook-sz
Copy link
Contributor Author

Ok awesome. I will get the rest of the updates pushed ASAP. Thanks again!

btw, i didnt need to install those because your guys' debugging tools in product are so good :)

Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from our security team and a comment response. The only blocker here is the axios version.

joshcanhelp
joshcanhelp previously approved these changes Mar 30, 2021
@joshcanhelp joshcanhelp merged commit 6b5e9b1 into auth0:master Apr 2, 2021
@joshcanhelp joshcanhelp changed the title Seczetta risk integration Seczetta risk integration + release v0.20.0 Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants