Update Rule headers and required configuration + release #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshcanhelp
commented
Sep 16, 2020
joshcanhelp
commented
- Add all configuration values to the Rule header
- Skip the Rule if required configuration is not present. If someone installs this Rule then hits Save without configuring, login is suddenly broken. That's a BIG gotcha. In this case, the Rule will simple not function until those values are saved.
joshcanhelp
commented
Sep 17, 2020
| @@ -42,8 +64,7 @@ function consentricIntegration(user, context, callback) { | |||
|
|
|||
| // Returns Consentric API Access Token (JWT) from either the global cache or generates it anew from clientId and secret | |||
| const getConsentricApiAccessToken = async () => { | |||
| const consentricApiTokenNotValid = (!global.consentricApiToken) || | |||
| global.consentricApiToken.exp < new Date().getTime(); | |||
| const consentricApiTokenNotValid = !global.consentricApiToken || global.consentricApiToken.exp < Date.now(); | |||
There was a problem hiding this comment.
Swap new Date().getTime() for Date.now()
joshcanhelp
commented
Sep 17, 2020
| @@ -19,13 +44,6 @@ async function iddatawebVerificationWorkflow(user, context, callback) { | |||
| configuration | |||
| ); | |||
|
|
|||
| const { | |||
joshcanhelp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.