Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require tests #221

Closed
wants to merge 3 commits into from
Closed

Add require tests #221

wants to merge 3 commits into from

Conversation

faroceann
Copy link
Contributor

@faroceann faroceann commented Feb 19, 2020

Description

This PR adds tests to exercise requires on all non-magic global template dependencies. This will allow us to ensure these dependencies work across different runtimes.

This PR also converts all rules templates to use named functions to improve linting [0].

References

DXEX-436

[0] https://community.auth0.com/t/getting-rid-of-identifier-expected-error-in-vscode-for-rules/10962

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants