fix: ios magic links handling #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jan 22, 2025
Widcket
approved these changes
Jan 22, 2025
Widcket
reviewed
Jan 22, 2025
Widcket
previously requested changes
Jan 22, 2025
|
@pmathew92 based on this thread here - react-native-community/discussions-and-proposals#671 We have to remove the namespace here for this PR - https://github.com/auth0/react-native-auth0/blob/master/android/src/main/AndroidManifest.xml |
pmathew92
changed the title
pmathew92
dismissed
Widcket’s stale review
Addresses the review comment with the latest push
Widcket
approved these changes
Jan 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of ASWebAuthenticatinSession not authenticating the user when user tries to login via magic links