added async signing #127
Merged
added async signing #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thank you! pulished as |
|
awesome!!! 👍 |
|
No problem! This library is a cornerstone for me, I'm happy to help. |
lukewestby
pushed a commit
to lukewestby/node-jsonwebtoken
that referenced
this pull request
Oct 2, 2015
To document changes from auth0#127
|
FYI: While this is great, it does not respect the error first callback convention. This unfortunately means that for instance this does not work with Bluebird's |
|
@Nepoxx since this function doesn't have a failure case would you suggest just always passing |
|
I'd say Changing this would break backwards compatibility. I think it should be changed to return Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #106. Feedback would be appreciated, especially around whether the unit test is sufficient. Thanks!