Fix destroying lock instance #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
reviewed
May 22, 2019
| @@ -7,7 +7,9 @@ export function observe(key, id, f) { | |||
| subscribe(`${key}-${id}`, (_, oldState, newState) => { | |||
| const m = getEntity(newState, 'lock', id); | |||
| const oldM = getEntity(oldState, 'lock', id); | |||
| if (m != oldM) f(m); | |||
| if (m && !m.equals(oldM)) { | |||
There was a problem hiding this comment.
Perhaps (m != null) would be safer? What types does getEntity return?
There was a problem hiding this comment.
they will always be different because m is an immutable object (which is a new reference, so will always be false if you compare with !=). that's why the fix is actually use .equals, which is an immutable method.
damieng
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #907, #1090, #1091
Changes
This is a copy of #1091, but I couldn't rebase because the original branch was removed.
This fixes a case where lock couldn't be destroyed
lock.destroy().