Hide password strength message when the password is valid #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
May 28, 2018
| @@ -104,6 +107,27 @@ exports[`PasswordPane sets isValid as true when \`isFieldVisiblyInvalid\` is fal | |||
| data-placeholder="placeholder" | |||
| data-policy="policy" | |||
| data-showPassword="showPassword" | |||
| data-showPasswordStrenghtMessage={false} | |||
There was a problem hiding this comment.
This property has a typo: Strenght -> Strength
| @@ -60,6 +61,12 @@ describe('PasswordPane', () => { | |||
|
|
|||
| expectComponent(<PasswordPane {...defaultProps} />).toMatchSnapshot(); | |||
| }); | |||
| it('sets showPasswordStrenghtMessage as true when `isFieldValid` is false', () => { | |||
There was a problem hiding this comment.
what about the opposite case?
luisrudge
force-pushed
the
fix-password-strenght-message
branch
from
ce1c8ad to
3f46992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1381
pre:
post:
