Skip to content

Commit

Permalink
Merge pull request #872 from nikolaseu/bugfix-cordova-disable-mfa-cod…
Browse files Browse the repository at this point in the history
…e-input

 Don't disable mfa-code input
  • Loading branch information
hzalaz authored Feb 17, 2017
2 parents 4c21d63 + c4706be commit feb4fe2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 24 deletions.
13 changes: 0 additions & 13 deletions src/__tests__/field/__snapshots__/mfa_code_pane.test.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,9 @@ Array [
]
`;

exports[`MFACodePane disables input when submitting 1`] = `
<div
data-__type="mfa_code_input"
data-disabled={true}
data-invalidHint="mfaCodeErrorHint,6"
data-isValid={false}
data-onChange={[Function]}
data-placeholder="placeholder"
data-value="mfa" />
`;

exports[`MFACodePane renders correctly 1`] = `
<div
data-__type="mfa_code_input"
data-disabled={false}
data-invalidHint="mfaCodeErrorHint,6"
data-isValid={false}
data-onChange={[Function]}
Expand All @@ -33,7 +21,6 @@ exports[`MFACodePane renders correctly 1`] = `
exports[`MFACodePane sets isValid as true when \`isFieldVisiblyInvalid\` is false 1`] = `
<div
data-__type="mfa_code_input"
data-disabled={false}
data-invalidHint="mfaCodeErrorHint,6"
data-isValid={true}
data-onChange={[Function]}
Expand Down
10 changes: 0 additions & 10 deletions src/__tests__/field/mfa_code_pane.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,6 @@ describe('MFACodePane', () => {
/>
).toMatchSnapshot();
});
it('disables input when submitting', () => {
require('core/index').submitting = () => true;
const MFACodePane = getComponent();

expectComponent(
<MFACodePane
{...defaultProps}
/>
).toMatchSnapshot();
});
it('sets isValid as true when `isFieldVisiblyInvalid` is false', () => {
require('field/index').isFieldVisiblyInvalid = () => false;
let MFACodePane = getComponent();
Expand Down
1 change: 0 additions & 1 deletion src/field/mfa-code/mfa_code_pane.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default class MFACodePane extends React.Component {
isValid={!c.isFieldVisiblyInvalid(lock, "mfa_code")}
onChange={::this.handleChange}
placeholder={placeholder}
disabled={l.submitting(lock)}
/>
);
}
Expand Down

0 comments on commit feb4fe2

Please sign in to comment.