Merge pull request #810 from auth0/fix-popup-mode

Fix: popup does not close when signup fails
auth0 · Jan 17, 2017 · c7385d9 · c7385d9
2 parents 8e17718 + ccebdd9
commit c7385d9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/connection/database/actions.js b/src/connection/database/actions.js
@@ -75,11 +75,14 @@ export function signUp(id) {
       });
     }
 
-    webApi.signUp(id, params, (error, ...args) => {
+    webApi.signUp(id, params, (error, result, popupHandler, ...args) => {
       if (error) {
+        if (!!popupHandler) {
+          popupHandler._current_popup.kill();
+        }
         setTimeout(() => signUpError(id, error), 250);
       } else {
-        signUpSuccess(id, ...args);
+        signUpSuccess(id, result, popupHandler, ...args);
       }
     });
   });

diff --git a/src/core/web_api/legacy_api.js b/src/core/web_api/legacy_api.js
@@ -73,7 +73,7 @@ class Auth0LegacyAPIClient {
 
     const popupHandler = (autoLogin && popup) ? this.client.popup.preload() : null;
 
-    this.client.signup(options, (err, result) => cb(err, result, popupHandler) );
+    this.client.signup(options, (err, result) => cb(err, result, popupHandler));
   }
 
   resetPassword(options, cb) {

diff --git a/src/core/web_api/p2_api.js b/src/core/web_api/p2_api.js
@@ -65,9 +65,7 @@ class Auth0APIClient {
 
     delete options.autoLogin;
 
-    const popupHandler = (autoLogin && popup) ? this.client.popup.preload() : null;
-
-    this.client.signup(options, (err, result) => cb(err, result, popupHandler) );
+    this.client.signup(options, (err, result) => cb(err, result));
   }
 
   resetPassword(options, cb) {