Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-safe classes should be Shared statically #462

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Thread-safe classes should be Shared statically #462

merged 2 commits into from
Dec 15, 2020

Conversation

lee157953
Copy link
Contributor

@lee157953 lee157953 commented Nov 23, 2020 •
edited
Loading

Thread-safe classes should be Shared statically,This improves performance and reduces class creation costs.

@lee157953
Thread-safe classes should be Shared statically
a787e2d 
Thread-safe classes should be Shared statically,This improves performance and reduces class creation costs.
@lee157953 lee157953 requested a review from a team as a code owner November 23, 2020 09:23
@jimmyjames jimmyjames self-requested a review December 15, 2020 19:32
@jimmyjames jimmyjames added this to the v3-Next milestone Dec 15, 2020
jimmyjames
jimmyjames approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeeHainie, this looks good 👍

@jimmyjames jimmyjames merged commit c540fae into auth0:master Dec 15, 2020
@jimmyjames jimmyjames modified the milestones: v3-Next, 3.12.0 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lee157953 @jimmyjames