-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple issuers #246 #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for the delay. I've left you some comments. Please remember to rebase the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion. I've left a few changes I need you to accept before merging this.
@itdevelopmentapps are you still interesting in merging this PR? Please, don't hesitate to ask any questions. |
@lbalmaceda please advise in what test you would like to see to increase coverage so that we can get this pull request accepted. |
By checking the coverage report, there are 2 missing branches.
I hope that's clear enough. It should help make the check green. |
@lbalmaceda we've added the suggested tests. |
Thank you. Will release before eow. |
Many thanks. |
Using Clojure this was a breaking change, got the following error:
When trying to call (.withIssuer Verification "example") After (.withIssuer Verification (into-array String ["example])) |
Added support for multiple issuers.
I wanted to change the previous pull request so I closed it, maybe if you guys can remove that one in favor for this one.
Many thanks.