Fix Date value conversion #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
date-conversion-fix
branch
from
f5d4624 to
b296262
Compare
nikolaseu
approved these changes
Feb 1, 2017
| Date date = deserializer.getDateFromSeconds(tree, "key"); | ||
| assertThat(date, is(notNullValue())); | ||
| assertThat(date.getTime(), is(seconds * 1000)); | ||
| assertThat(date.getTime(), is(2147493647L * 1000)); |
There was a problem hiding this comment.
Integer is always 32 bits on java?
it's weird how java makes you explicitly cast to (Object) sometimes, but when you sum a long to an int it doesn't care.
hzalaz
approved these changes
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for the Date value parsing.
Related #132