Fix/check nonce state hs256 tokens #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When you use HS256 tokens, idtoken-verifier will fail validation (because it only supports RS256). To get the token information, we use
/userinfo. Previously, we'd skip checking nonce and state from the id_token and call/userinfodirectly. This PR makes sure we check for nonce and state before calling/userinfo.I updated idtoken-verifier and a few test dependencies as well (make sure we're using the same test environment as idtoken-verifier).
Testing
[x] This change adds unit test coverage
[ ] This change adds integration test coverage