Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1836] Update state for local logouts #81

Merged
merged 6 commits into from
Aug 19, 2020
Merged

[SDK-1836] Update state for local logouts #81

merged 6 commits into from
Aug 19, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

logout({ localOnly: true }) doesn't cause a page refresh, so authenticated state should be updated after logout.

References

Fixes #72

Testing

Call logout({ localOnly: true })
Check that isAuthenticated is false and user is undefined

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added small This PR may require low effort to action, or contains few changes to review CH: Fixed PR is fixing a bug labels Aug 4, 2020
@adamjmcgrath adamjmcgrath requested a review from a team August 4, 2020 16:15
@adamjmcgrath adamjmcgrath changed the title Update state for local logouts [SDK-1836] Update state for local logouts Aug 4, 2020
@adamjmcgrath adamjmcgrath reopened this Aug 4, 2020
@adamjmcgrath
If you update state for idp logouts withAuthenticationRequired will…
3e9f622 
… attempt to log you back in before your redirect to the idP completes
@adamjmcgrath adamjmcgrath reopened this Aug 7, 2020
@adamjmcgrath adamjmcgrath merged commit 97e8ce5 into master Aug 19, 2020
@stevehobbsdev stevehobbsdev deleted the local-logout branch August 26, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling local logout does not clear auth0 provider's state
3 participants
@adamjmcgrath @stevehobbsdev @lbalmaceda