Make sure handleRedirectCallback is only called once in StrictMode React 18 #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handleRedirectCallback
can only be called once, multiple invocations will result in "Invalid State" errors since the first invocation has the side effect of clearing the transaction state (SessionStorage or cookies) causing the second invocation to fail.Because of this side effect
handleRedirectCallback
doesn't play well with the new Reusable State checks in StrictMode.When StrictMode remounts the
Auth0Provider
, the user hasn't logged in yet,handleRedirectCallback
fails and the SDK initialises as logged out before the firsthandleRedirectCallback
completes and initialises the SDK as logged in.One symptom of this is that If you have code that detects if the user is logged out and redirects them to login (like
withAuthenticationRequired
does) you can get in an infinite loop as even successful logins will briefly report failures.References
The recommended solution for code that can only be run once is to use a "ref"
reactwg/react-18/discussions/18
Fixes #343
Testing
Added test per reactwg/react-18/discussions/17
Checklist
master