Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1582] Normalize the auth0 error and add error handling to the basic example #10

Merged
merged 1 commit into from
May 19, 2020
Merged

[SDK-1582] Normalize the auth0 error and add error handling to the basic example #10

merged 1 commit into from
May 19, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 14, 2020 •
edited
Loading

Description

  • Normalize the auth0 error and add error handling to the basic example
  • Fix getToken return type

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested a review from a team May 14, 2020 15:03
@adamjmcgrath adamjmcgrath added small This PR may require low effort to action, or contains few changes to review CH: Added PR is adding feature or functionality labels May 14, 2020
@adamjmcgrath adamjmcgrath merged commit 32248fa into master May 19, 2020
@evansims evansims deleted the error-handling-docs branch July 5, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev