Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support earlier version of react and react-dom #96

Closed
tiagob opened this issue Aug 20, 2020 · 5 comments
Closed

Support earlier version of react and react-dom #96

tiagob opened this issue Aug 20, 2020 · 5 comments

Comments

@tiagob
Copy link

tiagob commented Aug 20, 2020

Describe the problem you'd like to have solved

Can you support an earlier version of react and react-dom? I'm using 16.11. It works fine but the warning is annoying. It's not possible to upgrade my version of react since this is in a mono-repo with an expo react-native app that requires 16.11 (latest version of expo).

Describe the ideal solution

Update these lines
https://github.com/auth0/auth0-react/blob/master/package.json#L92-L93

To

    "react": "^16.11.0",
    "react-dom": "^16.11.0",
@adamjmcgrath
Copy link
Contributor

Sure 👍 happy to accept a PR

tiagob added a commit to tiagob/auth0-react that referenced this issue Aug 20, 2020
@tiagob tiagob mentioned this issue Aug 20, 2020
4 tasks
adamjmcgrath pushed a commit that referenced this issue Aug 24, 2020
@tiagob
Copy link
Author

tiagob commented Sep 12, 2020

@adamjmcgrath are you publishing an update to npm anytime soon?

@adamjmcgrath
Copy link
Contributor

@tiagob - yep, planning on doing this tomorrow #115

@adamjmcgrath
Copy link
Contributor

@tiagob Released in 1.1.0

@tiagob
Copy link
Author

tiagob commented Sep 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants