Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Add macOS support to the example app [SDK-4699] 1/2 #354

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 21, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR adds support for macOS to the example app.

Screen.Recording.2023-11-21.at.19.01.34.mov

@Widcket Widcket requested a review from a team as a code owner November 21, 2023 19:06
@Widcket Widcket added the review:small Small review label Nov 21, 2023
@Widcket Widcket changed the title af: Add macOS support to the example app af: Add macOS support to the example app [SDK-4699] Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/macos-support@4fcb8b0). Click here to learn what that means.

❗ Current head 9cfa40d differs from pull request most recent head c226644. Consider uploading reports for the commit c226644 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/macos-support     #354   +/-   ##
========================================================
  Coverage                         ?   96.36%           
========================================================
  Files                            ?       98           
  Lines                            ?     1596           
  Branches                         ?      328           
========================================================
  Hits                             ?     1538           
  Misses                           ?       50           
  Partials                         ?        8           
Flag Coverage Δ
auth0_flutter 100.00% <0.00%> (?)
auth0_flutter_android 97.35% <0.00%> (?)
auth0_flutter_ios 99.85% <0.00%> (?)
auth0_flutter_platform_interface 87.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket changed the title af: Add macOS support to the example app [SDK-4699] af: Add macOS support to the example app [SDK-4699] 1/2 Nov 22, 2023
@Widcket Widcket merged commit 844e03c into feature/macos-support Nov 23, 2023
9 of 10 checks passed
@Widcket Widcket deleted the macos-support/example-app-macos branch November 23, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants