Upgrade Flutter used for build, and fix linter warnings #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
commented
Feb 23, 2023
stevehobbsdev
commented
Feb 23, 2023
| @@ -6,7 +6,7 @@ import 'constants.dart'; | |||
|
|
|||
| class ApiCard extends StatefulWidget { | |||
| final Future<void> Function(String usernameOrEmail, String password) action; | |||
| const ApiCard({required final this.action, final Key? key}) : super(key: key); | |||
There was a problem hiding this comment.
Fixes unnecessary final warnings, as these are implicitly final.
stevehobbsdev
changed the title
Codecov ReportBase: 98.68% // Head: 98.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
============================================
+ Coverage 98.68% 98.74% +0.06%
Complexity 82 82
============================================
Files 80 80
Lines 1441 1439 -2
Branches 320 320
============================================
- Hits 1422 1421 -1
+ Misses 7 6 -1
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Widcket
reviewed
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Primary motivation was that Ship CLI fails when running
flutter analyze(now returns a non-zero exit code even for warnings). Plus, good to keep up to date with latest Flutter anyway, and linter warnings should be fixed before they get out of hand.📎 References
🎯 Testing