Rename LocalAuthenticationOptions
to LocalAuthentication
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR renames the
LocalAuthenticationOptions
class to justLocalAuthentication
. This class is used as follows:Setting it will enable the local authentication feature, which is disabled by default. So it's actually modeling the local authentication feature itself, instead of simply holding settings for a feature that is already in use. As such, it should be called just
LocalAuthentication
, without theOptions
suffix.Compare it to the
IdTokenValidationConfig
class, which is used as follows:The ID token validation feature is always enabled. This class merely allows to configure it, so it has
Config
as part of the class name, and also as part of the parameter name. It is not modeling the feature itself.Config
andOptions
have pretty much the same meaning in this context, yet are being used in classes that have different roles and achieve different results, which is inconsistent and might be confusing.