Move scheme
to webAuthentication()
#150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently, Web Auth methods (login and logout) take a
scheme
parameter separately. Unlike the rest of the parameters, this one is not specific to each Web Auth method, but is something that applies to Web Auth in general (in Android). One would never specify a different value forlogin()
than forlogout()
.Thus this parameter belongs to the Web Auth instance itself.
webAuthentication()
already takes auseCredentialsManager
parameter for the same reasons. So havingscheme
inlogin()
andlogout()
would be inconsistent, and become a potential source of confusion.This PR moves
scheme
out oflogin()
andlogout()
, up intowebAuthentication()
.Before/after (usage)