Migrated project to Swift 5

[jjatie]

Changes

• Swift version bumped to 5
• Quick version bumped to 2.x
• Nimble version bumped to 8.x

References

• support ticket Swift 5 support #85

Testing

No code changes made. All unit test still build and pass.

Checklist

• I have read the Auth0 general contribution guidelines
• All existing and new tests complete without errors
• All active GitHub checks have passed

[cocojoe]

@jjatie Thanks, the hardest part is deciding to do a new major, as it feels it is time to follow suit of Quick/Nimble and drop Swift 3.x as both of these Libs no longer support it. Although you should be able to fix your PR to ensure 4.x runs. Not ready to drop that yet. (Ah this may be building...) Will come back in a bit to check.

[jjatie]

@cocojoe I'm not sure why the iOS builds are failing. My only guess is that it might have something to do with the Carthage caching?

[cocojoe]

So the migration here is a little more complicated, there are older tests for ObjC. This is also not supported now in Quick/Nimnble.

[jjatie]

@cocojoe Regarding dropping Swift 3 support seems like the obvious choice. It would require work just to be able to support tests for Swift 3. Swift 4 has been around for over 1.5 years.
Maintaining an app for modern Apple platforms requires the use of Swift 4, and for non-Apple platforms SPM (when it is introduced) solves any Swift version issues since 4/5 are source compatible.

[jjatie]

So the migration here is a little more complicated, there are older tests for ObjC. This is also not supported now in Quick/Nimnble.

I thought that might be the case, but couldn't find any mention of that in their release notes.

[cocojoe]

I remember seeing it in https://github.com/Quick/Nimble/releases/tag/v8.0.0

[quver]

Hello, what is the status of this pull request?

[cocojoe]

Tests don't pass, it will not be accepted like this.

[jjatie]

@cocojoe The one objective-c test we have doesn't pass because of the updates to Quick/Nimble.

@quver If you'd like to help, you can solve this issue.

[cocojoe]

Thanks for the PR, I had a pass on this in #88