Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to offset parent in getContainer #12

Closed
ausi opened this issue Feb 3, 2016 · 3 comments
Closed

Skip to offset parent in getContainer #12

ausi opened this issue Feb 3, 2016 · 3 comments
Assignees

Comments

@ausi
Copy link
Owner

ausi commented Feb 3, 2016

getContainer() should skip parent nodes of position: absolute elements until it finds a “positioned” parent. For position: fixed it should skip directly to the viewport.

@ausi ausi self-assigned this Feb 3, 2016
@rjgotten
Copy link

rjgotten commented Sep 30, 2016

For position: fixed it should skip directly to the viewport.

No, that's not particularly safe. Elements that have position:fixed are first positioned against the nearest ancestor that has a transform applied, before attempting to position against the viewport. You can only safely skip to the viewport if there is no such ancestor.

@ausi
Copy link
Owner Author

ausi commented Oct 6, 2016

You’re right. Thanks for the hint!

@ausi
Copy link
Owner Author

ausi commented Jun 12, 2017

Implemented in version 0.4.0.

@ausi ausi closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants