Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network config for defaults, add fallbacks to NearProvider constructor, remo… #64

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Add network config for defaults, add fallbacks to NearProvider constructor, remo… #64

merged 2 commits into from
Dec 11, 2020

Conversation

mikedotexe
Copy link
Contributor

…ve creation of test acct in constructor

As discussed here:
near/balancer-core#1 (comment)

Instead of having projects specify the nodeUrl every time, we can have them give the networkId and masterAccount (via environment variable) and have the network details living in this repo.

@mikedotexe mikedotexe requested a review from artob December 11, 2020 05:42
@artob artob self-assigned this Dec 11, 2020
artob
artob suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but will need to correct the walletUrl and explorerUrl links for betanet.

@artob artob assigned mikedotexe and unassigned artob Dec 11, 2020
@artob artob added the enhancement New feature or request label Dec 11, 2020
@mikedotexe mikedotexe requested a review from artob December 11, 2020 20:50
@mikedotexe mikedotexe mentioned this pull request Dec 11, 2020
Merged
@artob artob assigned artob and unassigned mikedotexe Dec 11, 2020
artob
artob approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging...

@artob artob merged commit b08e34f into master Dec 11, 2020
@artob artob deleted the hotfix/add-network-setups branch December 11, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artob artob artob approved these changes

Assignees

@artob artob

@mikedotexe mikedotexe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikedotexe @artob