This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Windows fixes and Windows CI #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niieani I will release this but can you send me some info on appveyor. We're using circle for everything else. Why do we need something else here? |
|
@EisenbergEffect AppVeyor is a CI which runs on Windows. I've added this in addition to CircleCI, which runs on Linux, because some things that work on Linux don't necessarily work on Windows, and we have many Windows users. This helps to maintain compatibility. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I broke the Windows build again with the last release. (and in fact we had some other problems with Windows in the other skeletons).
I've fixed them all (both CIs agree!). Here are the fixes.
In all future PRs so we can make sure nor Windows nor Linux is broken by any of them.