-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "filter_mode_list" configuration option #1655
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
2fc3d7d
to
9b7d98d
Compare
if settings.workspaces && self.search.context.git_root.is_some() { | ||
filter_modes.retain(|fm| *fm != FilterMode::Workspace); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this might be wrong, the condition should be wrapped in a !(...)
I guess.
I'll leave it this way until there's a decision whether this feature is desired or not. 😸
Also, this feature somewhat contradicts the |
Any ideas about this? |
I think it would make sense to add a So [search]
filters = ["session", "directory", "global"] When set, it will override Wrt workspaces, I'd suggest the following
|
I'd love to see this feature! |
Closes #1654
Maybe closes #366
Checks